Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Should nprogress remain a dependency? #2031

Open
NickSdot opened this issue Oct 14, 2024 · 2 comments · May be fixed by #2045
Open

[2.x] Should nprogress remain a dependency? #2031

NickSdot opened this issue Oct 14, 2024 · 2 comments · May be fixed by #2045

Comments

@NickSdot
Copy link

NickSdot commented Oct 14, 2024

I wanted to open this to ensure awareness and have it tracked.

The core package requires nprogress which seems more or less abandoned. The last 0.2.0 release on npm was 9 years ago.

4 years ago there was an attempt to release 1.0.0, which was tagged on GitHub but never made it as "latest" to npm.

Issues and merge requests are ignored; new packages spammed.

Not sure how I feel about such a dependency in general. Additionally, not everyone needs progress bars. And support for the navigation api (native spinners, yay!) in all major browsers seems only months away.🤏

I was wondering if Inertia v2 would be a good moment to drop mentioned dependency and make it (and it's Inertia wrapper) optional?

@SuperDJ
Copy link

SuperDJ commented Oct 16, 2024

Also many UI packages already include their own progress bar.

@NickSdot
Copy link
Author

NickSdot commented Oct 16, 2024

Also many UI packages already include their own progress bar.

Good point! And who still really wants it from Inertia can use the core-independent inertiajs/progress with no hustle (but still stuck on the abandoned nprogress).

@NickSdot NickSdot changed the title Should nprogress remain a dependency? [2.x] Should nprogress remain a dependency? Oct 18, 2024
@joetannenbaum joetannenbaum linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants