Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate fixed point logic in Cubit to allow for matching distance calculations #92

Open
clexmond opened this issue Jun 19, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request ODHack

Comments

@clexmond
Copy link
Member

Currently calculating distance in js in the SDK vs Cairo onchain results in slightly different values. Sometimes this can result in miscalculating lease rates, or other values. Ideally we could mimic (using BigInt math) the logic in acos_fast here https://github.com/influenceth/cubit/blob/main/src/f64/math/trig.cairo#L29 to do so.

@clexmond clexmond added enhancement New feature or request ODHack labels Jun 19, 2024
@fishonamos
Copy link

Let me work on this @clexmond .

@Chvx
Copy link

Chvx commented Jun 21, 2024

I can give this a try :)

@chachaleo
Copy link

Hey, if no one is still working on this I'd love to take it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ODHack
Projects
None yet
Development

No branches or pull requests

4 participants