Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass in offset time when creating alerts via API #580

Open
cklenk opened this issue Sep 22, 2023 · 3 comments
Open

Add ability to pass in offset time when creating alerts via API #580

cklenk opened this issue Sep 22, 2023 · 3 comments

Comments

@cklenk
Copy link

cklenk commented Sep 22, 2023

Proposal:
Add offset to CreateThresholdCheckAsync and CreateDeadmanCheckAsync for alerting

Current behavior:
Unable to set offset time when using CreateThresholdCheckAsync and CreateDeadmanCheckAsync methods

Desired behavior:
Pass in optional offset time with functions

Alternatives considered:
Manually create alerts

Use case:
Ease of development and cleaner solution

@powersj
Copy link
Contributor

powersj commented Sep 26, 2023

Hi,

When you say offset time, what is your use-case for this offset? Is it a delay in notification?

Thanks

@cklenk
Copy link
Author

cklenk commented Oct 9, 2023

Yes, that is correct. To account for late data that might come in.

Thanks,
Cameron

@powersj
Copy link
Contributor

powersj commented Oct 17, 2023

Based on the API docs, it does look like the threshold type check has a offset parameter that is not exposed in this client library.

We can investigate this further, but would also be happy to see a PR with a fix to include this parameter.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants