Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert as conversions to From/TryFrom #101

Open
crepererum opened this issue Feb 14, 2022 · 1 comment
Open

Convert as conversions to From/TryFrom #101

crepererum opened this issue Feb 14, 2022 · 1 comment
Assignees
@crepererum @pierwill
Labels
good first issue Good for newcomers

Comments

@crepererum
Copy link
Collaborator

The as conversions in our protocol code our quite dangerous and I think we might have a few integer overflow bugs in there. In general I think we should replace all as conversions with From and TryFrom to make it clear if the conversion can fail or not. There is also a clippy lint as_conversions which should be added to our code base to prevent regressions.
@crepererum crepererum added the good first issue Good for newcomers label Feb 14, 2022
@pierwill
Copy link
Contributor

pierwill commented Mar 8, 2022

👋 I'd like to work on this.

pierwill added a commit to pierwill/rskafka that referenced this issue Mar 9, 2022
@pierwill
Use a try_from instead of a cast
ecc8e22 
This is part of influxdata#101.
@pierwill pierwill mentioned this issue Mar 9, 2022
Merged
pierwill added a commit to pierwill/rskafka that referenced this issue Mar 9, 2022
@pierwill
fix: Use a try_from instead of a cast
0c648c8 
This is part of influxdata#101.
pierwill added a commit to pierwill/rskafka that referenced this issue Mar 10, 2022
@pierwill @crepererum
fix: Use a try_from instead of a cast
187dfbb 
This is part of influxdata#101.

Remove unneeded integer cast

Co-authored-by: Marco Neumann <[email protected]>
This was referenced Mar 10, 2022
Merged
Merged
Merged
@crepererum crepererum self-assigned this Aug 3, 2022
mykyta4876 added a commit to mykyta4876/rskafka that referenced this issue Sep 13, 2024
@mykyta4876 @crepererum
fix: Use a try_from instead of a cast
5cd4f40 
This is part of influxdata/rskafka#101.

Remove unneeded integer cast

Co-authored-by: Marco Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crepererum crepererum

@pierwill pierwill

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crepererum @pierwill