You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But we also need to authenticate the ibc-core messages that require membership proofs. Otherwise, spammers can submit empty dummy proofs successfully against any updated state root.
For example, for chan_open_try should start with a similar self.assert_owner() call here.
After #204, we now validate the sender in the client contract.
ibc-starknet/cairo-contracts/packages/clients/src/cometbft/component.cairo
Lines 61 to 67 in 4c63248
But we also need to authenticate the ibc-core messages that require membership proofs. Otherwise, spammers can submit empty dummy proofs successfully against any updated state root.
For example, for
chan_open_try
should start with a similarself.assert_owner()
call here.ibc-starknet/cairo-contracts/packages/core/src/channel/components/handler.cairo
Lines 78 to 84 in 4c63248
We should do it for other handlers like
conn_open_try
,chan_open_ack
,recv_packet
,ack_packet
etc -- anything that requires commitment proofs.The text was updated successfully, but these errors were encountered: