From c5d329e329f87190cc3bfcda82d5df4e1714e512 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Sun, 14 Apr 2024 22:13:11 +0200 Subject: [PATCH 1/2] Update various github actions and node versions --- .github/workflows/release.yml | 10 +++++----- .github/workflows/verify.yml | 34 +++++++++++++++++----------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7280e152f8..a7c8273af3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -14,19 +14,19 @@ jobs: steps: - uses: google/wireit@setup-github-actions-caching/v1 - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits fetch-depth: 0 - - name: Setup Node.js 16.x - uses: actions/setup-node@v3 + - name: Setup Node.js 20.x + uses: actions/setup-node@v4 with: - node-version: 16.x + node-version: 20.x registry-url: 'https://registry.npmjs.org' - name: Install Dependencies - run: npm install --ci + run: npm ci - name: Create Release Pull Request or Publish to npm id: changesets diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 94bfa380bf..22eec7046a 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -8,18 +8,18 @@ jobs: runs-on: ubuntu-latest steps: - uses: google/wireit@setup-github-actions-caching/v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Sanity check run: node ./scripts/lock-scan.js - - name: Setup Node 16.x + - name: Setup Node 20.x uses: actions/setup-node@v1 with: - node-version: 16.x + node-version: 20.x - name: Install Dependencies - run: npm install --ci + run: npm ci - name: Lint run: npm run lint @@ -32,15 +32,15 @@ jobs: runs-on: ubuntu-latest steps: - uses: google/wireit@setup-github-actions-caching/v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - - name: Setup Node 16.x - uses: actions/setup-node@v1 + - name: Setup Node 20.x + uses: actions/setup-node@v4 with: - node-version: 16.x + node-version: 20.x - name: Install Dependencies - run: npm install --ci + run: npm ci - uses: microsoft/playwright-github-action@v1 @@ -52,19 +52,19 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [16.x] + node-version: [20.x] os: [ubuntu-latest] steps: - uses: google/wireit@setup-github-actions-caching/v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Node ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - name: Install Dependencies - run: npm install --ci + run: npm ci - name: Test run: npm run test:node @@ -75,19 +75,19 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [16.x] + node-version: [20.x] os: [windows-latest] steps: - uses: google/wireit@setup-github-actions-caching/v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Node ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - name: Install Dependencies - run: npm install --ci + run: npm ci - name: Test run: npm run test:node From e15c5d8c95cdfb6f0c2050fc41b53083b8d2b59d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 15 Apr 2024 09:12:40 +0200 Subject: [PATCH 2/2] Downgrade to node@18 --- .github/workflows/release.yml | 4 ++-- .github/workflows/verify.yml | 14 +++++++------- .nvmrc | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a7c8273af3..7393089bc1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,10 +19,10 @@ jobs: # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits fetch-depth: 0 - - name: Setup Node.js 20.x + - name: Setup Node.js 18.x uses: actions/setup-node@v4 with: - node-version: 20.x + node-version: 18.x registry-url: 'https://registry.npmjs.org' - name: Install Dependencies diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 22eec7046a..d88227b64c 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -13,10 +13,10 @@ jobs: - name: Sanity check run: node ./scripts/lock-scan.js - - name: Setup Node 20.x - uses: actions/setup-node@v1 + - name: Setup Node 18.x + uses: actions/setup-node@v4 with: - node-version: 20.x + node-version: 18.x - name: Install Dependencies run: npm ci @@ -34,10 +34,10 @@ jobs: - uses: google/wireit@setup-github-actions-caching/v1 - uses: actions/checkout@v4 - - name: Setup Node 20.x + - name: Setup Node 18.x uses: actions/setup-node@v4 with: - node-version: 20.x + node-version: 18.x - name: Install Dependencies run: npm ci @@ -52,7 +52,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [20.x] + node-version: [18.x] os: [ubuntu-latest] steps: - uses: google/wireit@setup-github-actions-caching/v1 @@ -75,7 +75,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [20.x] + node-version: [18.x] os: [windows-latest] steps: - uses: google/wireit@setup-github-actions-caching/v1 diff --git a/.nvmrc b/.nvmrc index b6a7d89c68..3c032078a4 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16 +18