Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to jump to classes (ctrl +click) for METHOD^CLASS call #73

Open
Presumably opened this issue May 2, 2019 · 7 comments
Open

Comments

@Presumably
Copy link

No description provided.

@kdrozd
Copy link

kdrozd commented May 2, 2019

Nice idea. But the assumption method^Class is not correct, {subRoutine}^Routine.
With classes in PSL files, it will work nice but will hit you with PROC files where PROCEDURE is not always class and for sure its name can be different from its routine name which you are referring with M^R notation.

So to make this generic you should check which procedure will be compiled to routine name you are clicking. Probably this can be limited to procedures anyway as it's even more complicated with filers.

@atiplea
Copy link
Collaborator

atiplea commented May 2, 2019

PROC files where PROCEDURE is not always class

A simple solution will assume they are the same. I believe this is a requirement starting from 7.6

So to make this generic you should check which procedure will be compiled to routine name you are clicking

More complicated. Might not be implemented...

@kdrozd
Copy link

kdrozd commented May 2, 2019

Yes it is... but at the same time
select procid,pgm,des from DBTBL25 where procid<>pgm
is not empty.

@atiplea
Copy link
Collaborator

atiplea commented May 2, 2019

Of course. Still, having support for the simple case is still an improvement, and can be implemented with little effort.

Mapping procedure to routine for everything in the project will require some kind of in-memory structure that must be continuously refreshed. I'm putting off creating such a structure. However it would enable other improvements, for example a package explorer or saving CPU and time on unnecessary parsing.

@kdrozd
Copy link

kdrozd commented May 2, 2019

That's a great starting point :)
And maybe a simple validation for PROC files to check if PROCID==PGM?

@atiplea
Copy link
Collaborator

atiplea commented May 2, 2019

Great idea! I'll include them together :)

@cjprieb
Copy link
Contributor

cjprieb commented Sep 30, 2019

Has anyone started work on this yet? If not, I can see what I can do for the simple case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants