Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove artifacts and test reports history #113

Closed
5 tasks
codespool opened this issue Feb 24, 2023 · 0 comments · Fixed by #136
Closed
5 tasks

Remove artifacts and test reports history #113

codespool opened this issue Feb 24, 2023 · 0 comments · Fixed by #136
Assignees
@codespool
Labels
enhancement New feature or request
Milestone
Swanky Winter Won...

Comments

@codespool
Copy link
Collaborator

codespool commented Feb 24, 2023 •
edited
Loading

Overview (What and Why)

Keeping a history of artifacts has no practical advantage, and introduces unnecessary complexity to directory structure and config tracking.

How

  • stop tracking previous builds in config (ditch the timestamp)
  • overwrite the last build with new one
  • update all the commands that depend on artifacts

Definition of Done

  • changes are implemented and merged
  • docs updated

Open Issues and Blockers
@codespool codespool added the enhancement New feature or request label Feb 24, 2023
@codespool codespool moved this from 💡 New/Idea to 📋 Backlog (Commited) in Swanky Suite (legacy - moved to swankyhub) Feb 24, 2023
@codespool codespool moved this from 📋 Backlog (Commited) to 🏁 Ready to Start in Swanky Suite (legacy - moved to swankyhub) Feb 26, 2023
@codespool codespool moved this from 🏁 Ready to Start to 🏗 In progress in Swanky Suite (legacy - moved to swankyhub) Mar 15, 2023
@codespool codespool self-assigned this Mar 15, 2023
@codespool codespool mentioned this issue Mar 28, 2023
Closed
@codespool codespool linked a pull request May 8, 2023 that will close this issue
Feature/init convert #136
Merged
@codespool codespool mentioned this issue May 8, 2023
Merged
@codespool codespool moved this from 🏗 In progress to 👀 In review in Swanky Suite (legacy - moved to swankyhub) May 9, 2023
codespool added a commit that referenced this issue May 17, 2023
@codespool
Feature/init convert (#136)
0fde90c 
Main feature is introducing a `--convert` flag to `init` command. (#111
)
Also handled are #113 and #83 .

Some changes to how `init` works are introduced:
- all "tasks" now get pushed into the task queue and only executed after
all the options are confirmed
- config is also gathered in the global configBuilder, and written as
the last step

To test:
- have an existing project cloned to your filesystem (for example dex,
or nft from https://github.com/swanky-dapps)
- run `swanky init proj_name --convert path_to_existing_project`
- it will check for Cargo.toml with `workspace` `members` and `exclude`
fields
- it assumes `members` are contracts, and `exclude` are extra crates
- you can also specify manually
- when done, you still need to manually adjust import paths in the
contracts' Cargo.toml

Note: the converted project is not expected to work out-of-the-box when
converted, but should require minimum adjustments.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Swanky Suite (legacy - moved to swankyhub) May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codespool codespool

Labels
enhancement New feature or request
Projects
None yet
Milestone
Swanky Winter Wonderland
Development

Successfully merging a pull request may close this issue.

Feature/init convert inkdevhub/swanky-cli
1 participant
@codespool