Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedConceptMapper double-encodes query terms for matching #350

Open
fabianzwodrei opened this issue Dec 15, 2015 · 2 comments
Open

FederatedConceptMapper double-encodes query terms for matching #350

fabianzwodrei opened this issue Dec 15, 2015 · 2 comments
Labels
bug

Comments

@fabianzwodrei
Copy link

Searching with terms like "Ägypten" or "Türe und Tore" for matching concepts does not find the existing labels with the exact values.

My testing revealed that the FederatedConceptMapper uses encodeURIComponent() on a string that already has been encoded:

encodeURIComponent(encodeURIComponent("Ägypten")) = "%25C3%2584gypten" =/= "Ägypten"
@fabianzwodrei
Copy link
Author

Removing the encodeURIComponent() from federated_concept_mapper.js fixes it, but maybe there are side effects, because it's needed somewhere else.

@mjansing
Copy link
Contributor

Thank you for this bug report. I'll take a look at it soon.

@mjansing mjansing added the bug label Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianzwodrei @mjansing