Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monotonicity of EB inclusion in RBs? #232

Open
bwbush opened this issue Mar 6, 2025 · 4 comments
Open

Monotonicity of EB inclusion in RBs? #232

bwbush opened this issue Mar 6, 2025 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@bwbush
Copy link
Collaborator

bwbush commented Mar 6, 2025

I'm running the Haskell simulation with the default configuration and see that an EB generated in slot 80 is placed in an RB before the EB generated at slot 60 is. Is this a consequence of "freshest first"?

Image

@bwbush bwbush added the question Further information is requested label Mar 6, 2025
@bwbush bwbush changed the title Monotonicity of EB inclusion in RBs Monotonicity of EB inclusion in RBs? Mar 6, 2025
@Saizan
Copy link
Contributor

Saizan commented Mar 6, 2025

It's not because of the freshest-first diffusion config per se. I believe at some point the Short-Leios google doc specified that nodes should include the "freshest certified EB" when generating an RB, however I can't find this in the document anymore, nor see the version history.

@pagio in Short-Leios, how should an honest node choose the EB to include in an RB among the ones still eligible?

@bwbush
Copy link
Collaborator Author

bwbush commented Mar 7, 2025

Here is the plot showing when the RBs were generated. One can see that two EBs were ready to be included in RBs after RB production had paused.

Image

@pagio
Copy link
Contributor

pagio commented Mar 7, 2025

@Saizan The obvious way given the current formulation of things is to put in the RB the oldest EB that is still valid according to the EB freshness rule (EBs cannot be older than r_EB slots from the RB generation slot). Sorry for the ambiguity here, in Full Leios this is not really an issue.

@SupernaviX
Copy link
Contributor

The rust chooses the EB with the most TXs, to maximize throughput. I don't think haskell has equivalent logic, since IBs are all identical, but maybe choosing the EB with the most IBs would be similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants