Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Brakeman #1934

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Setup Brakeman #1934

wants to merge 4 commits into from

Conversation

bolom
Copy link
Contributor

@bolom bolom commented Apr 28, 2023

Brakeman doesn't support Ruby 2.4, as suggested by the gem's author in this conversation, I've used Brakeman-lib

@bolom bolom linked an issue Apr 28, 2023 that may be closed by this pull request
@ysbaddaden
Copy link
Contributor

@bolom Then how do you invoke Brakeman?

Another solution would be to stick to Brakeman 5.0. We don't need the latest version when we use old Ruby and Rails versions. As long as it supports Rails 5.0 this is fine. We'll upgrade it along with other dependencies as we continue to upgrade.

@bolom
Copy link
Contributor Author

bolom commented May 2, 2023

@bolom Then how do you invoke Brakeman?

We could maybe add a new action in Github action


 - name: Security audit application code
        run: bin/brakeman -q -w2

@ysbaddaden
Copy link
Contributor

Yeah, let's get Rubocop merged, and we can run Brakeman right after it.

@bolom bolom marked this pull request as draft May 19, 2023 00:59
@bolom
Copy link
Contributor Author

bolom commented May 26, 2023

@ysbaddaden not sure what I done wrong. every thing is red now :(

@ysbaddaden
Copy link
Contributor

Looking at the CI logs, it complains about Nokogiri::HTML4 being undefined. Looking at Nokogiri's documentation:

💡 Before v1.12.0, Nokogiri::HTML4 did not exist, and Nokogiri::HTML was the module/namespace for parsing HTML.

There is an invalid dependency. I see Loofah got upgraded and Nokogiri's stuck at 1.10. We don't want to upgrade Nokogiri without continuing with the Ruby/Rails upgrade (CDx uses Nokogiri directly for a XML user feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Brakeman
2 participants