-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Brakeman #1934
base: main
Are you sure you want to change the base?
Setup Brakeman #1934
Conversation
@bolom Then how do you invoke Brakeman? Another solution would be to stick to Brakeman 5.0. We don't need the latest version when we use old Ruby and Rails versions. As long as it supports Rails 5.0 this is fine. We'll upgrade it along with other dependencies as we continue to upgrade. |
We could maybe add a new action in Github action
|
Yeah, let's get Rubocop merged, and we can run Brakeman right after it. |
@ysbaddaden not sure what I done wrong. every thing is red now :( |
Looking at the CI logs, it complains about Nokogiri::HTML4 being undefined. Looking at Nokogiri's documentation:
There is an invalid dependency. I see Loofah got upgraded and Nokogiri's stuck at 1.10. We don't want to upgrade Nokogiri without continuing with the Ruby/Rails upgrade (CDx uses Nokogiri directly for a XML user feature). |
Brakeman doesn't support Ruby 2.4, as suggested by the gem's author in this conversation, I've used Brakeman-lib