Instructions file nih tables and fixes #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroradusky
changed the title
ysbaddaden
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1960.
Added instruction file to the NIH tables and, after iterating with the client, a few modifications were applied and some minor errors corrected:
copies/mlis not correct, it was changed tocopies/mL(in the reports and everywhere).uuid.TPRandFPRwere used as params for the challenge table, while the ones informed weresensitivity(theTPR) and thespecificity(which is1-FPR). The names of the params were corrected to reflect this.|and not with,Also, tests were fixed to reflect these changes.