Upgrade/ruby 2 3 rails 5 2 #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
reviewed
Dec 1, 2023
Dockerfile
Outdated
Comment on lines
6
to
9
| # Update to a newer Debian version if needed | ||
| # The below lines are for Debian Stretch, consider updating to Buster or Bullseye | ||
| RUN echo 'deb http://deb.debian.org/debian/ buster main\n\ | ||
| deb http://security.debian.org/debian-security buster/updates main' > /etc/apt/sources.list |
There was a problem hiding this comment.
We can remove these: debian:buster is maintained 🥳
Suggested change
| # Update to a newer Debian version if needed | |
| # The below lines are for Debian Stretch, consider updating to Buster or Bullseye | |
| RUN echo 'deb http://deb.debian.org/debian/ buster main\n\ | |
| deb http://security.debian.org/debian-security buster/updates main' > /etc/apt/sources.list |
There was a problem hiding this comment.
You might even be able to remove the let's encrypt CA fix above (maybe).
There was a problem hiding this comment.
The above applies to Dockerfile-dev also :)
Gemfile
Outdated
| @@ -1,12 +1,12 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| # frameworks | |||
| gem 'rails', '~> 5.0.0', '>= 5.0.0.1' | |||
| gem 'rails', '~> 5.2.Z', '>= 5.2.8.1' | |||
There was a problem hiding this comment.
This is enough:
Suggested change
| gem 'rails', '~> 5.2.Z', '>= 5.2.8.1' | |
| gem 'rails', '~> 5.2.8' |
This allows to select any 5.2.x version starting from 5.2.8 and above.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the project to Ruby 2.7 & Rails 5.2.
It was developed on top of the previous pull request (import resmap collection) and it should be merged properly after the other PR is approved.
Upgrades:
Some gem versions have to be fixed and just a few tweaks were needed, building pipeline are working OK.