Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do expired contacts in the channel-broker consume retries? #2284

Open
ysbaddaden opened this issue Jun 6, 2023 · 2 comments · Fixed by #2298
Open

Do expired contacts in the channel-broker consume retries? #2284

ysbaddaden opened this issue Jun 6, 2023 · 2 comments · Fixed by #2298
Labels
Milestone

Comments

@ysbaddaden
Copy link
Contributor

If contacts are queued in the channel-broker but expire before they can be sent to verboice (or nuntium after #2283), the channel-broker will merely discard the contacts, and won't report the expired state back to the respondent session.

How will the session consider the respondent? Does the session assume that we tried to contact the respondent, and failed, and consumes a retry when it shouldn't? Or correctly assume that we didn't get any response, and won't consume a retry... ⏰

That won't crash or hang surveda. The batch size / limit per minute can be tuned to avoid too many excess contacts. The logs regularly report the number of active & queued contacts for each channel-broker, which may help to tweak the batch size / limit values.

If it's an issue, it might be fixed by the channel-broker making an internal call to report the contact as expired. That should be doable.

@ysbaddaden ysbaddaden added this to the 0.37.1 milestone Jun 6, 2023
@ysbaddaden
Copy link
Contributor Author

Here is a screenshot of local survey where roughly 1600 IVR contacts expired yesterday evening (the simulator is confirmed to always reply). It seems that Surveda reported them as failed, which might hint that it will consume a retry to call them again?

Capture d’écran de 2023-06-06 14-04-34@2x

@ysbaddaden ysbaddaden linked a pull request Aug 31, 2023 that will close this issue
@ysbaddaden
Copy link
Contributor Author

Likely fixed by #2298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: On hold
Development

Successfully merging a pull request may close this issue.

1 participant