Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelBroker: simplify & optimize the active calls collector #2302

Open
ysbaddaden opened this issue Sep 12, 2023 · 0 comments
Open

ChannelBroker: simplify & optimize the active calls collector #2302

ysbaddaden opened this issue Sep 12, 2023 · 0 comments

Comments

@ysbaddaden
Copy link
Contributor

The ChannelBrokerState.clean_inactive_respondents/1 function is meant to cleanup the inactive respondents, yet it takes a list of active respondents and the :collect_garbage handler of the channel-broker load all active respondents, and we must always load all of them (e.g. we can't paginate).

The logic should be reversed. Loading only the list of inactive respondents would load less respondent ids and allow to do the cleanups in batches.

See #2297 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant