Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinecone] Add rerank task #1114

Open
ShihChun-H opened this issue Sep 24, 2024 · 18 comments · May be fixed by instill-ai/pipeline-backend#773
Open

[Pinecone] Add rerank task #1114

ShihChun-H opened this issue Sep 24, 2024 · 18 comments · May be fixed by instill-ai/pipeline-backend#773
Assignees
Labels
component feature New feature or request good-first-issue Good for newcomers hacktoberfest hacktoberfest2024 Component improvement issues for Hacktoberfest 2024 help-wanted Help from the community is appreciated improvement Improvement on existing features instill core Label

Comments

@ShihChun-H
Copy link
Member

ShihChun-H commented Sep 24, 2024

Issue Description

Current State*

  • Current Pinecone does not support Rerank task

Why We Want to Change?*

  • Pinecone introduces the rerank API

Proposed Change*

  • Reduce the fields on the node.
  • Mark the password as secret

Rules for the Component Hackathon

  • Each issue will only be assigned to one person/team at a time.
  • You can only work on one issue at a time.
  • To express interest in an issue, please comment on it and tag @kuroxx, allowing the Instill AI team to assign it to you.
  • Ensure you address all feedback and suggestions provided by the Instill AI team.
  • If no commits are made within five days, the issue may be reassigned to another contributor.
  • Join our Discord to engage in discussions and seek assistance in #hackathon channel. For technical queries, you can tag @chuang8511.

Component Contribution Guideline | Documentation | Official Go Tutorial

@ShihChun-H ShihChun-H added documentation Improvements for instill.tech/docs tutorial Improvements for instill.tech/tutorials need-triage Need to be investigated further hacktoberfest2024 Component improvement issues for Hacktoberfest 2024 labels Sep 24, 2024
Copy link

linear bot commented Sep 24, 2024

@ShihChun-H ShihChun-H added help-wanted Help from the community is appreciated improvement Improvement on existing features feature New feature or request instill core component and removed documentation Improvements for instill.tech/docs tutorial Improvements for instill.tech/tutorials need-triage Need to be investigated further labels Sep 24, 2024
@chuang8511 chuang8511 added the good-first-issue Good for newcomers label Sep 25, 2024
@MubeenKodvavi
Copy link

@ShihChun-H

Please assign this task to me, I will add this functionility.
We need to leverage this API: https://docs.pinecone.io/reference/api/2024-10/inference/rerank

Some questions:
Pinecone is a data component. Do we need to rerank tasks through a data component?
Should we not introduce a seperate ai component for pinecone, or doing this with data is fine?

@MubeenKodvavi
Copy link

This should be integrated once rerank API is in stable release.
Currently, the API is available in version 2024-10 of Pinecone API which is a release-candidate.

@ShihChun-H
Copy link
Member Author

Hi @chuang8511, Could you help clarify the question raised by @MubeenKodvavi? Thanks!

@ShihChun-H
Copy link
Member Author

Hi @MubeenKodvavi, thanks for your offer to take on this task. Currently, our policy allows only one assigned issue per contributor at a time. I’ll assign this to you as soon as your current task is completed. Thanks for understanding! 🙌🏻

@donch1989
Copy link
Member

Hi @MubeenKodvavi
Thank you for taking on this task. Although reranking is an advanced AI feature, it is frequently used in the scope of data operations. We believe it is still appropriate to include reranking in this data component as well.

@aazam-gh
Copy link

aazam-gh commented Oct 2, 2024

Hi, can I be assigned this issue :)

@ShihChun-H
Copy link
Member Author

Hi @MubeenKodvavi, since you have already completed the issue assigned to you. Would you like to work on this issue next?

@ShihChun-H
Copy link
Member Author

Hi @aazam-gh, there is a queue for this issue, would you mind waiting for a bit? 🙏

@aazam-gh
Copy link

aazam-gh commented Oct 2, 2024

Sure I'll look into other ones

@MubeenKodvavi
Copy link

@ShihChun-H
As I mentioned before, this issue should be implemented when the Rerank API is available in the stable version of the Pinecone API.
Currently, Pinecone API defaults to the latest release version, which is 2024-07. However, the Rerank API is not available in this version.
We can specify the 2024-10 version in the headers if we need this feature before 2024-10 is stable.
Image

You can assign this task to me, and I can raise a PR. However, I suggest waiting until the 2024-10 version is officially released before merging, as it is expected to be available by the end of this month. Reference: Pinecone API Versioning

@ShihChun-H
Copy link
Member Author

Hi @MubeenKodvavi Totally understand the circumstance.
I will assign this issue to you, and you can submit the PR after the 2024-10 version is officially released. This ensures that the assignment remains with you throughout the process, and won't be taken away from you 🙌🏻

@kuroxx
Copy link
Collaborator

kuroxx commented Oct 15, 2024

Hey @MubeenKodvavi how's it going? Just checking the status of this task - has there been any updates?
In the meantime, feel free to join our Discord server to share & support others with component development: discord.gg/sevxWsqpGh

@MubeenKodvavi
Copy link

Hi @kuroxx , I will raise a PR for it this weekend.

@MubeenKodvavi
Copy link

MubeenKodvavi commented Oct 29, 2024

@ShihChun-H @kuroxx can you please request a review of linked PR from the team? Thank you :)

@kuroxx
Copy link
Collaborator

kuroxx commented Oct 29, 2024

Hey @MubeenKodvavi yes will pass it on to the team!! Thanks for raising 🤝

@kuroxx
Copy link
Collaborator

kuroxx commented Oct 30, 2024

Hey @MubeenKodvavi could you check the feedback in your PR and update accordingly, thanks! 🙇

@kuroxx
Copy link
Collaborator

kuroxx commented Nov 4, 2024

Hey @MubeenKodvavi thank you for submitting PRs for Hacktoberfest, I wanted to let you know that we will need a PR by the end of this week (8th Nov) since we are closing this event.

Please submit:

to ensure your contribution is counted!

Alternatively, if you cannot complete this within the time frame but would still like to contribute, you are more than welcome to but please note it would not be within the scope of Hacktoberfest 2024.

Thank you and look forward to your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component feature New feature or request good-first-issue Good for newcomers hacktoberfest hacktoberfest2024 Component improvement issues for Hacktoberfest 2024 help-wanted Help from the community is appreciated improvement Improvement on existing features instill core Label
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

7 participants