-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Flexible Data Cleansing Functionality for Enhanced Text Processing #760
base: main
Are you sure you want to change the base?
Conversation
@chuang8511 Kindly review whenever you have time. |
Hi @NailaRais
Thank you again! |
Hello @chuang8511 @kuroxx I have added feature to fetch json in main.go and below is the unit test code which should be added to main_test.go and recipe. Updated Main_test.go
Recipe
|
Hey @NailaRais could you commit your unit test Main_test.go into your PR instead of leaving it as a comment, thanks! 🙏 |
Hi @NailaRais Your PR still lack the JSON schema that we provided before. Please fetch the schema within this PR. And, please clean your commit history with command like And, I found the regex actually can easily fulfil the substring function. So, we won't need substring clean method now. |
Because
CleanData
function allows for better code organization and reuse, making it easier to manage and update cleansing logic in the future.This commit
CleanData
,CleanDataInput
,CleanDataOutput
, andDataCleaningSetting
structs to facilitate data cleansing operations.Execute
method to include a new case for handling data cleansing tasks, ensuring the system can process cleansing jobs appropriately.