New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractSqlProvider: count on boolean value problem #387

Open

aclDeveloper opened this issue Apr 19, 2023 · 0 comments

Contributor

aclDeveloper commented Apr 19, 2023

Q	A
Bug report	yes
Feature request	no
BC Break report	no
RFC	no
Branch	master

Found a potential problem in the import definition in AbstractSqlProvider.php on line 42:
if (count($data) > 0) { .... }

Here on line 38:
$data = $query->fetchAssociative();

the result can be false (bool) and count on bool is not allowed.

The problem occurred in PHP8.0 in Pimcore 10.5.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment