Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of ImportDefinition is returned when getting ExportDefinition by ID #425

Closed
wants to merge 5 commits into from

Conversation

paulverdu
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #424

Correctly set a unique value for the settingsStoreScope key in Import- and ExportDefinition DAO's for PimcoreLocationAwareConfigDao to correctly load in the corresponding data.

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@paulverdu
@paul Verdu
Paul Verdu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dpfaffenbauer
Copy link
Collaborator

@paulverdu thanks, perfect. please sign the cla and off we go

@paulverdu
Copy link
Contributor Author

@dpfaffenbauer Yeah. I'm trying to figure out how 😅

@paulverdu paulverdu closed this Oct 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants