Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/#515/display invalid yaml error message #551

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Bug/#515/display invalid yaml error message #551

merged 4 commits into from
Feb 4, 2025

Conversation

aevo98765
Copy link
Member

@aevo98765 aevo98765 commented Feb 4, 2025 •
edited by vishnoianil
Loading

Fixes: #515

@aevo98765 aevo98765 self-assigned this Feb 4, 2025
@vishnoianil
Copy link
Member

@aevo98765 Skill/Native also required the similar changes ?

@aevo98765
Copy link
Member Author

I missed skills native. I covered the other three. Changed now and should be functional on all 4 forms.

vishnoianil
vishnoianil approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit af27a84 into instructlab:main Feb 4, 2025
5 checks passed
This was referenced Feb 7, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnoianil vishnoianil vishnoianil approved these changes

@nerdalert nerdalert Awaiting requested review from nerdalert

Assignees

@aevo98765 aevo98765

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: If you try and upload an invalid yaml submission with the upload yaml no error is produced to the user
2 participants
@aevo98765 @vishnoianil