Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions to "pulls" feature not working #1960

Open
lamontadams opened this issue Sep 27, 2024 · 7 comments
Open

Subscriptions to "pulls" feature not working #1960

lamontadams opened this issue Sep 27, 2024 · 7 comments
Labels

Comments

@lamontadams
Copy link

Describe the bug
I'm not receiving notifications of PRs in a repo subscribed via /github subscribe owner/repo pulls. /github subscribe list features confirms the repo is subscribed to the pulls feature. Subscriptions to pulls in the same repo worked correctly in a different slack account - we have migrated to a new account due to acquisition and no subscriptions work on new slack account.

Unsure if dupe of #1833 or not, please advise if so and will close.

To Reproduce
Steps to reproduce the behavior:

  1. In a slack channel with the github app installed: /github subscribe owner/repo pulls
  2. Confirm subscription via /github subscribe list features
  3. Got to owner/repo in github, create a PR
  4. Note no notification appears in the subscribed slack channel.

Expected behavior
Notification appears in the subscribed slack channel when a PR is created.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Noted in Mac, Linux and IOS
  • Browser: NA (Desktop App)
  • Version: Slack 4.40.128
@angeliquejw
Copy link

Here to report the same issue. Our team originally subscribed to a repo in June and things worked as expected. On 9/23, we attempted to subscribe to a second repo's pull requests and have not seen anything from the repo, despite the fact that /github subscribe list features shows the second repo.

@mfitz
Copy link

mfitz commented Oct 1, 2024

We're experiencing the same problem, both for PRs and issues.

Nothing unusual happened when subscribing to the repo from the Slack channel, and list features also looks normal:

/github subscribe list features

<group>/<repo>
issues, pulls, commits:'main', releases, deployments, reviews, branches, comments

We see notifications when new branches and releases are created but not when PRs or issues are created, or when comments are added to an issue.

We can create new issues on the repo from the Slack channel, so "pushing" to issues is working, but "pulling" from them is not.

Repos with older subscriptions are not affected; we still see Slack notifications for PRs and issues from those repos.

@holyspectral
Copy link

Same here. I setup a new integration this afternoon and it doesn't work at all. Hope this can be fixed soon.

@tigris
Copy link

tigris commented Oct 3, 2024

:+1: here, i have a hacky solution for those impacted.

I setup /github subscribe org/repo issues pulls and it wasn't working. However, if I setup /github subscribe org/repo to get all the defaults, and then do /github unsubscribe org/repo commits releases deployments it works.

Doing /github subscribe list features shows no differences in the above two scenarios, but the latter works for us at the moment.

@nnamacha
Copy link

nnamacha commented Oct 7, 2024

Experiencing the same issue

@snankani snankani removed their assignment Oct 10, 2024
@lamontadams
Copy link
Author

This seems to have suddenly started working again for us on Wednesday 10/9. I'll leave the ticket open but it looks like this may be resolved?

@mfitz
Copy link

mfitz commented Oct 14, 2024

Same here, this is now working again for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants