Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Refactor assigning value ibpi_prev in _send_msg. #235

Open
bkucman opened this issue Jun 14, 2024 · 0 comments
Open

[ENHANCEMENT] Refactor assigning value ibpi_prev in _send_msg. #235

bkucman opened this issue Jun 14, 2024 · 0 comments
Assignees

Comments

@bkucman
Copy link
Contributor

bkucman commented Jun 14, 2024

Description

Currently, the send message function assigns the pattern determined by ledmon every time, regardless whether the controller returned a success or not. This mechanism should start recognizing whether the pattern was written successfully, and handle these states accordingly.

Reason

  • Failure of the controller to write supported pattern leads to the fact that there will be no attempt to enter it again, because the controller does not attempt to write it if actual ibpi is the same as prev.
  • incorrect patterns determined by ledmon are also entered into ibpi_prev, which seems logically incorrect, such a case should have its own error handling, it may hide an error in implementation or events.

Environment

N/A

@ktanska ktanska self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants