Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of gallery pipeline #64

Open
3 tasks
Pennycook opened this issue Aug 22, 2024 · 0 comments
Open
3 tasks

Improve testing of gallery pipeline #64

Pennycook opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Pennycook
Copy link
Contributor

Feature/behavior summary

#37 introduced a GitHub Action to run the gallery, which will make it easier for us to inspect the images generated after certain changes. If we could find a way to automatically identify whether any of the generated images have meaningfully changed, that would save us the hassle of having to check the images manually.

Request attributes

  • Would this be a refactor of existing code?
  • Does this proposal require new package dependencies?
  • Would this change break backwards compatibility?

Related issues

No response

Solution description

@laserkelvin suggested that we might be able to use a "perceptual hash" to compare the generated graphs against previously generated graphs, as it may be more robust than something like MD5/SHA-512 if something moves a little bit.

Additional notes

We probably wouldn't want the action to fail just because an image changed (since it may be deliberate). Some sort of warning directing our attention to a files that should be double-checked by a human would be good enough.

@Pennycook Pennycook added enhancement New feature or request help wanted Extra attention is needed labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant