Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer computes count width 0 when only 1 element in deserialized #166

Open
mkorbel1 opened this issue Feb 3, 2025 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Feb 3, 2025

Describe the bug

If a single element is passed into a Serializer (i.e. deserialized is a 1D array with 1 element), then the width of count is determined to be 0, which then breaks the assignment to the output of the Counter since it always has at least 1 bit.

To Reproduce

Create a Serializer with a 1D array with 1 element in it passed in.

Expected behavior

The Serializer should always have 1-bit output on count probably, or at least it should build properly and drive outputs in a way that makes sense.

Actual behavior

Signal count has the wrong width. Expected 0 but found 1.

Additional: Dart SDK info

No response

Additional: pubspec.yaml

Additional: Context

No response

@mkorbel1 mkorbel1 added bug Something isn't working good first issue Good for newcomers labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant