Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort "List Users" endpoint? #47

Open
tejasmanohar opened this issue Aug 12, 2016 · 7 comments
Open

Sort "List Users" endpoint? #47

tejasmanohar opened this issue Aug 12, 2016 · 7 comments

Comments

@tejasmanohar
Copy link

How do you sort the "List Users" data?

@choran
Copy link
Member

choran commented Aug 12, 2016

At the moment you cannot sort data via the list users functionality. i..e you cannot set a sort field at the moment. It this what you mean? i.e. how do you sort data similar to the API for list users?

@tejasmanohar
Copy link
Author

Yeah, meant setting a sort field. Alright, I'll send a PR. It seems you can here- https://developers.intercom.io/reference

@choran
Copy link
Member

choran commented Aug 21, 2017

Hi @tejasmanohar
Thanks for submitting the PR and sorry for not getting to it yet.
Should be able to get to it this week
Cheers
Cathal

@tejasmanohar
Copy link
Author

@choran Ooh, there are merge conflicts now (almost a yr later :P). I'm no longer using this library and don't remember the context of this well so if these changes are valuable, it may be best to incorporate them outside of my PR or amend it on your end. Sorry!

@choran
Copy link
Member

choran commented Aug 22, 2017

Hi @tejasmanohar,
Yeah, that is fair enough. We are making an effort to get to these regularly now so that they do not remain inactive for so long. For now I will make this a work needed and close the PR for now.
Thanks for submitting that and apologies for not getting to it before

@tejasmanohar
Copy link
Author

All good! Thanks

@choran
Copy link
Member

choran commented Sep 11, 2017

np, I will leave this issue open in the meantime since, as noted, it is functionality that would be useful in the sdk

@mmartinic mmartinic added dev and removed dev labels Jul 5, 2018
@keloe keloe added dev and removed dev labels Jul 5, 2018
@choran choran added the go label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants