Show author names next to final result in author merge tool #10297
Conversation
|
@ananyakaligal are you sure all the commits you want are here? The diff looks like only a variable was renamed. |
|
cool |
RayBB
added
the
Needs: Staff / Internal
There was a problem hiding this comment.
Taking a look at this one while on a call with @RayBB , @mekarpeles !
Thank you @ananyakaligal !
|
@cdrini I think your comments on this one didn't come through with the PR review :/ |
| @@ -191,11 +191,11 @@ export default { | |||
| }, | |||
|
|
|||
| async merge() { | |||
| if (!this.master_key || !this.records || !this.editions) | |||
| if (!this.master_key || !this.enhancedRecords || !this.editions) | |||
There was a problem hiding this comment.
Darn :D Ah the issue was here; we don't want to use the enhancedRecords during the merge, since that will result in the extra author name fields being saved to Open Library! We just want the fields for display.
So you will likely have to create a helper method that can run this function with either .records or .enhancedRecords, and use one for the actual merge that's saved to Open Library, and the other just for display. Let us know if you have any questions 👍
cdrini
added
Needs: Submitter Input
Closes #10292
Adds author names next to the merged works in the merge view, improving clarity by making it easier to identify duplicate authors. It ensures author names are shown consistently throughout the process, not just next to unmerged works.
Technical
Added enhancedRecords to the merge function in
MergeTable.vueTesting
npm run serve --component=MergeUI.Screenshot
Stakeholders
@RayBB