From e5bb242d34253e289bea4c25f0e1b397e6d28f29 Mon Sep 17 00:00:00 2001 From: Omar Salah Date: Mon, 17 Feb 2025 19:27:16 +0200 Subject: [PATCH] Refactor importActorProfile function to streamline error handling and remove redundant console logs --- src/index.ts | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/index.ts b/src/index.ts index e54dd2c..13ea28c 100644 --- a/src/index.ts +++ b/src/index.ts @@ -192,13 +192,7 @@ export async function importActorProfile( console?: Pick onError?: (error: Error, context: { fileName?: string }) => void } = {} - tarStream: Readable, - options: { - console?: Pick - onError?: (error: Error, context: { fileName?: string }) => void - } = {} ): Promise> { - const { console = undefined } = options const { console = undefined } = options const extract = tar.extract() const result: Record = {} @@ -230,22 +224,15 @@ export async function importActorProfile( if (fileName.endsWith('.json')) { result[fileName] = JSON.parse(content) console?.log('Parsed JSON file successfully:', fileName) - console?.log('Parsed JSON file successfully:', fileName) } else if (fileName.endsWith('.yaml') || fileName.endsWith('.yml')) { result[fileName] = YAML.parse(content) } else if (fileName.endsWith('.csv')) { result[fileName] = content } else { console?.warn(`Unsupported file type: ${fileName}, skipping...`) - console?.warn(`Unsupported file type: ${fileName}, skipping...`) } } catch (error: any) { - const errorMessage = `Error processing file ${fileName}: ${error.message}` - if (onError) { - onError(new Error(errorMessage), { fileName }) - } else { - reject(new Error(errorMessage)) - } + next(error) } finally { next() // Always continue } @@ -260,19 +247,16 @@ export async function importActorProfile( }) extract.on('finish', () => { - console?.log('All files processed successfully.') console?.log('All files processed successfully.') resolve(result) }) extract.on('error', (error) => { - console?.error('Error during tar extraction:', error.message) console?.error('Error during tar extraction:', error.message) reject(new Error('Failed to extract tar file.')) }) tarStream.on('error', (error) => { - console?.error('Error in tar stream:', error.message) console?.error('Error in tar stream:', error.message) reject(new Error('Failed to process tar stream.')) })