bug: unknown user ids go through to be mentioned

[thetayloredman]

Before we begin...

• I've checked the issue checker and ensured this is not a duplicate

What's your version of Intersection?

Intersection v1.0.0 (git b1bc8e4, dirty source tree), compiled by rustc 1.70.0 (90c541806 2023-05-31) for x86_64-unknown-linux-gnu (debug build) on Sunday, July 23, 2023 1:15 PM (8 minutes ago)

How are you using Intersection?

Locally, for development

Describe the bug you are experiencing.

If you run a query like @{ <@123> } with an invalid user ID or one that is not a member of the current server, it still passes.

Describe the steps needed to reproduce this bug.

Run a query like @{ <@123> } or use a user ID not currently in this server

What did you expect to happen?

An error mentioning the user ID was invalid or not a member of this server

What actually happened?

The query passed:

Search Terms

invalid user id

Additional Context

this needs to be fixed within the resolve_user_id resolver by adding an extra validator. we could also choose to validate if an ID has the correct length within the lexer? this might provide a worse error though

[thetayloredman]

Confirmations:

• Intersection v1.0.0 (git f912721), compiled by rustc 1.70.0 (90c541806 2023-05-31) for x86_64-unknown-linux-gnu (debug build) on Sunday, July 23, 2023 2:50 PM (20 seconds ago)
• PRODUCTION INSTANCE: Intersection v1.0.0 (git 5a05ca1), compiled by rustc 1.71.0 (8ede3aae2 2023-07-12) for x86_64-unknown-linux-gnu (release build) on Saturday, July 15, 2023 9:25 PM (8 days ago)

[thetayloredman]

could invalid user ids break unionize sets?