Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential security issue: only redirect to HTTP URL in dev builds #6

Open
carreter opened this issue Jan 29, 2023 · 0 comments · May be fixed by #7
Open

Potential security issue: only redirect to HTTP URL in dev builds #6

carreter opened this issue Jan 29, 2023 · 0 comments · May be fixed by #7

Comments

@carreter
Copy link

carreter commented Jan 29, 2023

While doing #5 , I noticed a potential security issue.

In handleLogin() in client/src/components/App.js, the redirect to Fireroad is passed a redirect=<url> query parameter. This URL is set to be via HTTP instead of HTTPS if the user's URL includes localhost:5000. I could potentially see this being a security risk if someone sneaks this string into the URL and then captures the Fireroad auth token via a man in the middle attack.

Regardless, this behavior should be configured via a build flag instead of trying to guess whether it's being run in dev. Will make a stacked PR on top of #5 that does this.

@carreter carreter linked a pull request Jan 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant