Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parent Issue] datamodel: still todo #54

Closed
ppanero opened this issue Feb 11, 2020 · 1 comment
Closed

[Parent Issue] datamodel: still todo #54

ppanero opened this issue Feb 11, 2020 · 1 comment

Comments

@ppanero
Copy link
Member

ppanero commented Feb 11, 2020

TODO as outcome of #49:

  • Implement versioning (conceptrecid minting)
  • OAI serializing/schema, add to tests and fixtures.
  • Customization of enums
  • Resource types are loaded from a JSON file. We need to converge on how to load them, for all enums.
  • IdentifierScheme could be reused in many other schemas. However, there is no easy and clean way to flatten its attributes. Tested Pluck and Method. The latter worked but it has a more difficult code comprehension, which in my perspective makes is not a good choice.
  • Tests for access_condition since the access part is not fully defined yet. It is not added to the fixtures either.
  • Tests for FilesSchema, since is dump_only (see Zenodo). How should this be tested?
  • Access: Combine / disambiguate _access and access_right  #37
@ppanero ppanero mentioned this issue Feb 11, 2020
@fenekku
Copy link
Contributor

fenekku commented Feb 27, 2020

Breaking this up into smaller issues and closing:

@fenekku fenekku closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants