Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Filter based on parameter value #4851

Open
SchrodingersGat opened this issue May 18, 2023 · 12 comments
Open

[FR] Filter based on parameter value #4851

SchrodingersGat opened this issue May 18, 2023 · 12 comments
Assignees
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Fund This issue can be specifically funded for development part Related to Part models User Interface Related to the frontend / User Interface
Milestone

Comments

@SchrodingersGat
Copy link
Member

SchrodingersGat commented May 18, 2023

After #4823 is completed, add ability to define custom filters for the 'parametric part table' based on parameter value

e.g.

  • ?param_3_gt=9000 : Find parts with length > 9,000mm
  • ?param_4=0402 : Find components with package 0402

Support operators like:

-eq (equality)

  • lt (less than)
  • gt (greater than)

Would have to use some complex queryset annoations on the server (much like in #4823) to make this performant

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature part Related to Part models labels May 18, 2023
@agooddaytowork
Copy link

Hi @SchrodingersGat
Have you been working on this? I really need this feature to be implemented.

In case you have not worked on this feature, I would like to implement this my self locally first. Could you drop more guidelines on where I should start?

@SchrodingersGat
Copy link
Member Author

@agooddaytowork no work on this to date, so if you want to take it on, that's great!

References

As a starting point, look at these recent PRs which have added parameter filtering, and parameter units:

Currently we support:

  • Sorting parts by specific parameter value
  • Filtering parts which have a particular parameter value associated

also check out the filter_parametric_data function which was implemented in the PRs above:

def filter_parameteric_data(self, queryset):

Let me know if you need any other pointers! Be very keen to see this feature get off the ground.

@github-actions
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Sep 15, 2023
@SchrodingersGat
Copy link
Member Author

Not stale. @agooddaytowork did you ever get anywhere with this? Would be keen to see this working :)

@agooddaytowork
Copy link

@SchrodingersGat

I made some updates but not going anywhere near what I want. I'm snuggling to get used to the UI part.
you could take a look at this PR. https://github.com/agooddaytowork/InvenTree/pull/1/files

@github-actions github-actions bot removed the inactive Indicates lack of activity label Sep 16, 2023
@SchrodingersGat SchrodingersGat added User Interface Related to the frontend / User Interface user interface api Relates to the API labels Oct 19, 2023
@SchrodingersGat
Copy link
Member Author

@agooddaytowork given the user interface changes requied to get this to work, I think we should park it until the react user interface is further along...

@matmair
Copy link
Member

matmair commented Oct 19, 2023

@agooddaytowork the API work looks intresting.
Do you mind opening a PR against (this) upstream repo so we can discuss and maybe build a UI around it?

Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Dec 19, 2023
@SchrodingersGat
Copy link
Member Author

Not stale. @agooddaytowork any updates on this from your end?

@github-actions github-actions bot removed the inactive Indicates lack of activity label Dec 20, 2023
@SchrodingersGat SchrodingersGat added the Fund This issue can be specifically funded for development label Feb 2, 2024
@SchrodingersGat SchrodingersGat self-assigned this Feb 2, 2024
@matmair
Copy link
Member

matmair commented Feb 22, 2024

@agooddaytowork any status on this on the backend? We could probably integrate it easily into the new frontend.

Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Apr 23, 2024
@SchrodingersGat SchrodingersGat added this to the horizon milestone Apr 23, 2024
@SchrodingersGat SchrodingersGat removed the inactive Indicates lack of activity label Apr 23, 2024
@SchrodingersGat
Copy link
Member Author

Not stale. Adding to horizon milestone

@matmair matmair changed the title [Feature] Filter based on parameter value [FR] Filter based on parameter value Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Fund This issue can be specifically funded for development part Related to Part models User Interface Related to the frontend / User Interface
Projects
None yet
Development

No branches or pull requests

3 participants