Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Settings to contrl editing of "completed" orders #8976

Open
SchrodingersGat opened this issue Jan 28, 2025 · 2 comments
Open

[UI] Settings to contrl editing of "completed" orders #8976

SchrodingersGat opened this issue Jan 28, 2025 · 2 comments
Assignees
Labels
order Related to purchase orders / sales orders User Interface Related to the frontend / User Interface
Milestone

Comments

@SchrodingersGat
Copy link
Member

As a hangover from the old user interface we have the following global settings:

  • PURCHASEORDER_EDIT_COMPLETED_ORDERS
  • SALESORDER_EDIT_COMPLETED_ORDERS
  • RETURNORDER_EDIT_COMPLETED_ORDERS

If enabled, the intent is that the line items for the particular orders cannot be edited once the order has been "completed".

This was only ever a UI limitation - no back-end or API restrictions were enforced.

The question is:

  • Do we wish to re-implement this concept for the new user interface?
  • Do we remove these three settings

@matmair @wolflu05 any particular strong feelings here? My preference would be to remove them.

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed question This is a question triage:not-checked Item was not checked by the core team User Interface Related to the frontend / User Interface order Related to purchase orders / sales orders and removed bug Identifies a bug which needs to be addressed triage:not-checked Item was not checked by the core team labels Jan 28, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Jan 28, 2025
@matmair
Copy link
Member

matmair commented Jan 28, 2025

@SchrodingersGat my intuitive expectation would be that this locking is the default behavior.

Good that we found this with the refactor - I can volunteer to re-implement it if that is the outcome we come too. Long term I would like to have a generalized locking system but that is v3 territory probably.

@SchrodingersGat
Copy link
Member Author

@matmair ok, let's go with:

Immediate - re-implement this as a UI feature, optionally locking the line items from being edited if the order is completed or cancelled
Longer term - checks are performed on the backend / general purpose "locking" system

@matmair matmair removed the question This is a question label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
order Related to purchase orders / sales orders User Interface Related to the frontend / User Interface
Projects
None yet
Development

No branches or pull requests

2 participants