Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage reports #523

Closed
remojansen opened this issue Apr 2, 2017 · 6 comments
Closed

Fix test coverage reports #523

remojansen opened this issue Apr 2, 2017 · 6 comments

Comments

@remojansen
Copy link
Member

The cov reports are not working. More info at inversify/inversify-express-utils#41 (comment)

@dcavanagh
Copy link
Member

dcavanagh commented Apr 3, 2017

The problem is with gulp-mocha ^4.0. sindresorhus/gulp-mocha#159
I tried reverting gulp-mocha to ^3.0 and the code coverage worked again.

@lholznagel
Copy link
Contributor

Just as a general idea and to prevent things like this, maybe we should lock the dependency versions? I mean we have greenkeeper enabled.

@remojansen
Copy link
Member Author

@lholznagel I know but this is an odd one because 3.0 and 4.0 is a breaking change. But the build is successful and the coverage reports are not available :(

@dcavanagh
Copy link
Member

dcavanagh commented Apr 5, 2017

@remojansen What if you check that the coverage report is not empty?
This fails the build

var report = require('./coverage/coverage-final.json');
    if (Object.keys(report).length === 0) {
        throw new Error("no test coverage");
    }
    return ret;

@remojansen
Copy link
Member Author

@AltekkeE That sounds like a good way to prevent this issue in the future. Thanks for sharing it 👍

@remojansen
Copy link
Member Author

Rolled back to 3.0.1 will wait until gulp-mocha fixes the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants