Add support for anyof_ref #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
These two PRs should actually merge nicely with each other. I first implemented the feature in #69 and later added this feature, but both work together in my repo. I'll help with the merging when it comes time and resolve any conflicts. Sorry for the delay. I addressed the review feedback. PTAL. |
Signed-off-by: Glenn Lewis <[email protected]>
samlown
reviewed
Sep 6, 2023
| @@ -37,6 +37,8 @@ type TestUser struct { | |||
| BirthDate time.Time `json:"birth_date,omitempty" jsonschema:"oneof_required=date"` | |||
| YearOfBirth string `json:"year_of_birth,omitempty" jsonschema:"oneof_required=year"` | |||
| Metadata interface{} `json:"metadata,omitempty" jsonschema:"oneof_type=string;array"` | |||
| IPAddress2 interface{} `json:"ip_address2,omitempty" jsonschema:"anyof_ref=#/$defs/ipv4;#/$defs/ipv6"` | |||
There was a problem hiding this comment.
I don't think these are important enough to stick in the README. I think the best way forward here is with some custom tests inside the refect_test.go file.
|
This is now fixed in #92. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #71.