This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
fix(Webpack): fix webpack callback for fatal error #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the implementation of the [run method of webpack compiler](https://github.com/webpack/webpack/blob/master/lib/Compiler.js #L180), the callback function can be called without passing any `stats` in the case of a fatal error, e.g. when using the option `bail` of webpack. fix ionic-team#46
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the implementation of the [run method of webpack
compiler](https://github.com/webpack/webpack/blob/master/lib/Compiler.js
L180), the callback function can be called without passing any
statsin the case of a fatal error, e.g. when using the option
bailofwebpack.
fix #46