Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Android app linking fails due to empty hosts #229

Open
QuentinFarizon opened this issue Jun 9, 2020 · 14 comments
Open

Android app linking fails due to empty hosts #229

QuentinFarizon opened this issue Jun 9, 2020 · 14 comments

Comments

@QuentinFarizon
Copy link

QuentinFarizon commented Jun 9, 2020

Using the latest version of this plugin, app linking verification isn't launched due to extraneous empty hosts

By "isn't launched", I mean:

  • verification process is not event launched : there is no logcat entry for SingleHostAsyncVerifier nor IntentFilterIntentOp
  • adb shell dumpsys package d show no entry for my app (whereas when a verification fails there is at least an entry with "ask")

Not working :

            <intent-filter android:autoVerify="true">
                <action android:name="android.intent.action.VIEW" />
                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <data android:host="www.boks.app" android:pathPrefix="/" android:scheme="https" />
                <data android:host=" " android:pathPrefix="/" android:scheme=" " />
                <data android:host=" " android:pathPrefix="/" android:scheme=" " />
                <data android:host=" " android:pathPrefix="/" android:scheme=" " />
                <data android:host=" " android:pathPrefix="/" android:scheme=" " />
            </intent-filter>

Working :

            <intent-filter android:autoVerify="true">
                <action android:name="android.intent.action.VIEW" />
                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <data android:host="www.boks.app" android:pathPrefix="/" android:scheme="https" />
            </intent-filter>

I have tested this on 3 different Android devices and Android versions.

I think you should find a way to remove the entries for extra hosts when these hosts are not defined. Or maybe if they were empty instead of containging a space ?

@zero-1
Copy link

zero-1 commented Jun 15, 2020

I am debugging a similar issue in a cordova app at the moment. The app links haven't been working for past few weeks.
Did you find a workaround for this issue ??
Or at least how were you able to test by removing the entries with blank values... ..

Is there a way to manually change the "generated" AndroidManifest.xml file in the ionic/cordova build process ???

@QuentinFarizon
Copy link
Author

QuentinFarizon commented Jun 15, 2020 via email

@dmitry-salnikov
Copy link

dmitry-salnikov commented Apr 28, 2022

Same issue, empty hosts entries break app linking completely on Android 12.

@geshub
Copy link

geshub commented Oct 2, 2022

In my case it's not breaking app linking but I can see issues for the empty hosts on the google play console in the deep links category.

@sirineKr
Copy link

Same case as @geshub. Errors in deep link view in google play console due to empty host.

@baraaksayeth
Copy link

same as @geshub. I have errors in play console about deep link.
image

Is there any way to solve it?

@geshub
Copy link

geshub commented Dec 5, 2022

@baraaksayeth I fixed it by filling all the empty deeplinks hosts, schemes and prefixes with dummy values.

@baraaksayeth
Copy link

fixed it by filling all the empty deeplinks hosts, schemes and prefixes with dummy values.

@geshub Is it possible to fill all empty deeplink with the same value?

@geshub
Copy link

geshub commented Dec 5, 2022

@baraaksayeth I think it's safer to do it with links you're not using than repeating the same. I've got no errors on my deeplinks on google play console.

@baraaksayeth
Copy link

@baraaksayeth I think it's safer to do it with links you're not using than repeating the same. I've got no errors on my deeplinks on google play console.

@geshub Is there any promblems with verification domain if I fill with empty host etc.?

@geshub
Copy link

geshub commented Dec 5, 2022

@baraaksayeth probably yes, I filled it with dummy directories on my existing and verified domain.

@baraaksayeth
Copy link

@geshub so you fill only with different path but the domain is still same right?

@geshub
Copy link

geshub commented Dec 5, 2022

@geshub so you fill only with different path but the domain is still same right?

@baraaksayeth correct

@baraaksayeth
Copy link

image

I don't know why it still happens to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants