Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code coverage #11

Open
morrisonbrett opened this issue Mar 28, 2017 · 5 comments
Open

Adding code coverage #11

morrisonbrett opened this issue Mar 28, 2017 · 5 comments

Comments

@morrisonbrett
Copy link

Would be great if code coverage was added to this. I'm working on getting it working with karma-coverage, but the instructions all don't really support @angular/cli and don't support webpack.

@lathonez
Copy link
Contributor

I am also looking at this, will let you know if I get something working

@lathonez
Copy link
Contributor

#12

@morrisonbrett
Copy link
Author

I'm going to add a sample mock to your fork.

@lathonez
Copy link
Contributor

@morrisonbrett - I agree that example mocks are a good thing and we should get them included in this repo, but I can't see what they have to do with test-coverage or what use it would do adding them to a fork.

Why don't you create a separate PR on this repo adding the mock?

@morrisonbrett
Copy link
Author

Good point. I'll do that.

sandrozbinden added a commit to IMSmobile/app that referenced this issue Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants