fix(runtime): only hydrate styles on client side #6174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@danielleroux thanks, I've been also running into this and raised a fix in #6175 .. since it comes with test I will go with this one. Thanks though 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: Fixes #6166
What is the new behavior?
Check if window object is defined before query elements.
ToDo:
Note: Repo: https://github.com/artursopelnik/stenciljsnextjs15-ssr is not runnable from the instructions mentioned in the README
Result: Looks from ds-ouput-target perspective.
Documentation
Does this introduce a breaking change?
Testing
Any ideas how to test it inside the stencil repository?