We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The related PR: #1279
Questions:
WalletData
WalletInner
WalletData::bip_path
WalletBuilder
WalletBuilder::with_address_generation_method
RemainderValueStrategy::ChangeAddress
WalletBuilder::with_address
get_addresses_to_sync
here
AddressWithUnspentOutputs
bech32_hrp
Wallet
get_bech32_hrp
Questions (CLI):
WalletCommand
CliCommand
addresses
new-address
command
InitParameters
addresses_balance
WalletCommand::Balance
Todos:
accounts_and_addresses
sdk/src/wallet/storage/constants.rs
Potential bugs:
account_addresses
account_and_nft_addresses
can_output_be_unlocked_now
The text was updated successfully, but these errors were encountered:
Has been split into different issues
Sorry, something went wrong.
Alex6323
No branches or pull requests
The related PR: #1279
Questions:
WalletData
andWalletInner
? yes, but it should be renamed (RenameWalletData
#1903)WalletData::bip_path
really be optional ? yes, but theWalletBuilder
should be changed (AddWalletBuilder::with_address_generation_method
or something similar #1904)RemainderValueStrategy::ChangeAddress
? (yes for now)WalletBuilder::with_address
? (no, needs change: AddWalletBuilder::with_address_generation_method
or something similar #1904)get_addresses_to_sync
and similar functionality? (fn already removed?, buthere
is where we're requiring it)AddressWithUnspentOutputs
? (yes, but simplified: Cleanup wallet syncing code #1905)bech32_hrp
from Account inWallet
, andget_bech32_hrp
? (yes)Questions (CLI):
WalletCommand
CliCommand
or just rename them? (no)addresses
/new-address
command
? (no for now)InitParameters
Bip44 parsing the way it is here? (yes for now)InitParameters
? (sort of yes, AddWalletBuilder::with_address_generation_method
or something similar #1904)addresses_balance
method? There isWalletCommand::Balance
(yes, Bring backaddresses_balance
method #1907 )Todos:
accounts_and_addresses
examples (Renameaccounts_and_addresses
#1909)WalletData
(yes, RenameWalletData
#1903)sdk/src/wallet/storage/constants.rs
(constants look good)Potential bugs:
account_addresses
andaccount_and_nft_addresses
fromcan_output_be_unlocked_now
just seems wrong (Update/Fixcan_output_be_unlocked_now
fn #1911)The text was updated successfully, but these errors were encountered: