Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run go tests with CGO=0 #91

Open
galargh opened this issue Sep 28, 2024 · 2 comments
Open

feat: run go tests with CGO=0 #91

galargh opened this issue Sep 28, 2024 · 2 comments

Comments

@galargh
Copy link
Member

galargh commented Sep 28, 2024

It has been suggested that

more and more of the base stack is being careful to avoid CGO where possible
it would be great to have a per-repository flag to run all the tests with CGO disabled, so that future regressions are easily caught

The way to run the tests is: CGO_ENABLED=0 go test
@ribasushi
Copy link

The way to run the tests is: CGO_ENABLED=0 go test

Do note - the important part for test/compilation/debug is CGO_ENABLED=0. Whether you specifically use go test after that or some other process/workflow is free-form.

@ribasushi
Copy link

@galargh another area where CGO_ENABLED=0 is crucial:

For Go programs that don’t need cgo, a reproducible build is as simple as compiling with CGO_ENABLED=0 go build -trimpath. Disabling cgo removes the host C toolchain as a relevant input, and -trimpath removes the current directory.

galargh added a commit that referenced this issue Nov 28, 2024
@galargh
feat(#91): simplify disabling CGO for the Go tests
3a21e0c
galargh added a commit that referenced this issue Nov 28, 2024
@galargh
feat(#91): simplify disabling CGO for the Go tests
c39f999
galargh added a commit that referenced this issue Dec 4, 2024
@galargh
implement the november batch of unified github workflows improvements (…
c482816 
…#100)

* chore(#69): do not install go twice when not needed

* feat(#91): simplify disabling CGO for the Go tests

* fix(#89): do not release -dev/-rc versions as latest

* chore(#86): mark go updating PRs as breaking changes

* chore(#70): remove usage of search api from releaser workflow

* fix: the second go setup conditional in go-test

* fix: the second go setup conditional in go-check

* fix: the second go setup conditional in go-test

* fix: the cgo enabled config key retrieval

* fix: finding merge pr in releaser

* fix: finding merge pr in releaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ribasushi @galargh