Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grow graph as DAGNodes are loaded? #11

Open
achingbrain opened this issue May 22, 2019 · 4 comments
Open

Grow graph as DAGNodes are loaded? #11

achingbrain opened this issue May 22, 2019 · 4 comments
Labels
design-visual Visual design

Comments

@achingbrain
Copy link
Member

Loading big graphs is really slow because the UI waits for the whole thing to be loaded before rendering - could it add nodes to the graph as they come in instead?

@ericronne ericronne added design design-visual Visual design and removed design labels May 24, 2019
@alanshaw
Copy link
Member

We struggled with this initially, it could maybe look good when building it in traversal order i.e. after import, animate from the root node.

However, the DAG is actually created from bottom up, and the importer doesn't yield individual DAG nodes so there's a difference between what's happening in reality and what we'd be animating.

At the time we punted on this feature so we didn't confuse people, and it felt like a big time sink to get it working nicely. I've since added a loading spinner which should help with the UX a little.

@parkan
Copy link

parkan commented May 28, 2019

I was able to use the tool successfully yesterday with a smaller file, but today I tried to upload a ~4MB MP3 a couple of times and it ballooned the tab to >1GiB memory usage and tons of CPU, and eventually froze (it seemed to be working rather hard after the "added" message in console so it sounds like the viz itself it pretty heavy?), now the site won't load at all

hopefully I didn't kill it 😬

what I was attempting to determine was: would pre-loading the files ahead of time be quicker? seems like the answer might be "no" given that constructing the actual viz seems to be the heavy bit

@alanshaw
Copy link
Member

If you're adding big files (bigger than say 100KB) then crank up the chunk size so there's fewer nodes to render in the graph.

There's no server component so you probably didn't break it! 😉

@parkan
Copy link

parkan commented May 28, 2019

fair enough, 512b chunks yielded way too many nodes 😄 and the other downtime (?) seems to have been a coincidence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-visual Visual design
Projects
None yet
Development

No branches or pull requests

4 participants