Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different TOML package #45

Open
riley-harper opened this issue Oct 7, 2022 · 2 comments
Open

Use a different TOML package #45

riley-harper opened this issue Oct 7, 2022 · 2 comments
Labels
configuration Related to configuration and its syntax
Milestone

Comments

@riley-harper
Copy link
Contributor

riley-harper commented Oct 7, 2022

The TOML parser that we're using appears to be unmaintained, or at least not regularly updated. It has some known bugs that keep it from matching the TOML standard, and some of the error messages are not particularly helpful. The tomli crate is a newer crate that will be added into the standard library in Python 3.11 as tomllib. Let's move to using tomli instead of toml. I believe some of our dependencies are already using tomli, so this will actually reduce the number of packages installed in the environment.

This may change how hlink handles some configuration files, especially ones that do not meet the TOML standards.

@riley-harper
Copy link
Contributor Author

See also #35.

@riley-harper riley-harper changed the title Use a newer TOML package Use a different TOML package Dec 7, 2022
@riley-harper riley-harper added this to the v4.0.0 milestone Oct 30, 2023
@riley-harper riley-harper added the configuration Related to configuration and its syntax label Aug 27, 2024
@riley-harper
Copy link
Contributor Author

Make sure that tomli is available in the runtime dependencies, not just the dev dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to configuration and its syntax
Projects
None yet
Development

No branches or pull requests

1 participant