WaveCache.module_op already returns the MLIR module str #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb0807
force-pushed
the
fix
branch
6 times, most recently
from
97c3f6b to
50009f5
Compare
--------- Signed-off-by: tyb0807 <[email protected]>
|
I believe this is only true when the compilation is cached. See #419 (unless the non-cache path has changed since then) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
AttributeError: 'str' object has no attribute 'get_asm'error when running pytest withWAVE_DUMP_MLIR=1@harsh-nod @raikonenfnu