Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Move WaveConstraint related convention into the WaveConstraint … #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NFC] Move WaveConstraint related convention into the WaveConstraint … #537

wants to merge 1 commit into from
+23 −13

Conversation

nicolasvasilache
Copy link
Contributor

…class

@Hardcode84
Copy link
Contributor

Hardcode84 commented Feb 27, 2025 •
edited
Loading

Some tests are flaky and can be ignored:

FAILED tests/dynamo/tensor_test.py::TensorTest::test_nn_linear - RuntimeError: allocating memory on queue: ABORTED
FAILED tests/dynamo/tensor_test.py::TensorTest::test_unary_op - RuntimeError: allocating memory on queue: ABORTED

But some seems to be broken for real

FAILED tests/kernel/wave/runtime/cache_test.py::testSameSizeDifferentBlock - AssertionError: Wave id already set

@nicolasvasilache nicolasvasilache force-pushed the users/nico/nfc-convention branch from b9805aa to b478d19 Compare February 27, 2025 13:28
@nicolasvasilache nicolasvasilache force-pushed the users/nico/nfc-convention branch from b478d19 to 73c29ab Compare February 27, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardcode84 Hardcode84 Hardcode84 approved these changes

@harsh-nod harsh-nod Awaiting requested review from harsh-nod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasvasilache @Hardcode84