[DT] Add an option to not hoist infusible encoding ops out of dispatch. #20017
+177
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experimental path that disables the hoisting. The main purpose is to keep the same number of dispatches. Otherwise, they'd result in their own dispatch. The control function (that adds the operations to candidate set) can be relaxed once we have encoding propagation better. Signed-off-by: hanhanW <[email protected]>
Max191
requested changes
Feb 21, 2025
There was a problem hiding this comment.
If we want to add controls on this, then we should do it at the level of SetEncoding. One of the main points of data tiling/encodings as I understand it is to fuse or propagate the layout transformation of the input operands with a producer or consumer. Having a set_encoding in the same dispatch as its user seems to be counterproductive in all cases, because the layout for the dispatch has not changed, and now you are effectively doing something that could be done entirely within codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental path that disables the hoisting. The main purpose is to keep the same number of dispatches. Otherwise, they'd result in their own dispatch.
The control function (that adds the operations to the candidate set) can be relaxed once we have better encoding propagation.