Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Sample's name caues a cache miss #135

Open
gordonwatts opened this issue Jun 5, 2024 · 1 comment
Open

Changing Sample's name caues a cache miss #135

gordonwatts opened this issue Jun 5, 2024 · 1 comment
Labels
bug Something isn't working servicex Related to SX tests
Milestone

Comments

@gordonwatts
Copy link
Member

gordonwatts commented Jun 5, 2024

In the code below, Name is set to a particular thing. If you run, and then re-run you'll get a cache hit. Which is as expected. However, if you change only the Name, the cache seemed to miss, which is unexpected.

    spec = sx.ServiceXSpec(
        General=sx.General(
            ServiceX="atlasr22",
            Codegen=query[1],
            OutputFormat=sx.ResultFormat.root,  # type: ignore
            Delivery=("LocalCache" if download else "SignedURLs"),  # type: ignore
        ),
        Sample=[
            sx.Sample(
                Name=f"speed_test_{ds_name}"[0:128],
                RucioDID=ds_name,
                Codegen=query[1],
                Query=query[0],
                NFiles=num_files,
                IgnoreLocalCache=ignore_cache,
            )  # type: ignore
            for ds_name in ds_names
        ],
    )

Also, changing the name can cause one to have two entries in the hash database code for the query cache. I've also seen that in other circumstances (btw):

@gordonwatts gordonwatts added bug Something isn't working servicex Related to SX tests labels Jun 5, 2024
@gordonwatts gordonwatts added this to the Post Test milestone Jun 5, 2024
@ketan96-m
Copy link

@gordonwatts Tested this with one example, didn't encounter this bug. If it works as expected we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working servicex Related to SX tests
Projects
None yet
Development

No branches or pull requests

2 participants