Adding Resource Fields for api.Machine
#203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
controllers
enhancement
lukas016
requested changes
Feb 23, 2024
| @@ -765,7 +765,7 @@ func (r *MachineReconciler) setDomainResources(machine *api.Machine, domain *lib | |||
| } | |||
| } | |||
|
|
|||
| cpu := uint(machine.Spec.CpuMillis / 1000) | |||
| cpu := uint(machine.Spec.Resources.CPU().Value() / 1000) | |||
There was a problem hiding this comment.
this logic is wrong. 8.6 will be rounded down to 8 what doesn't make sense for me. I prefer do rounded up.
@afritzler do we need support millis unit? Cannot we support just whole cores? 1, 2, 3, 4, 5, 6, 7, 8, ...
lukas016
reviewed
Feb 23, 2024
| @@ -31,6 +31,7 @@ type MachineSpec struct { | |||
| } | |||
|
|
|||
| type MachineStatus struct { | |||
| NUMAPlacement NUMAPlacement `json:"numaPlacement,omitempty"` | |||
There was a problem hiding this comment.
here maybe you will need to add ResourceList too
lukas016
reviewed
Feb 23, 2024
| type ResourceName string | ||
|
|
||
| const ( | ||
| ResourceCPU ResourceName = "cpu" |
There was a problem hiding this comment.
pls don't create own ResourceName or type. Ideally reuse core package: core "github.com/ironcore-dev/ironcore/api/core/v1alpha1"
|
Closing since not anymore relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181