Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Add missing tests #62

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add missing tests #62

merged 1 commit into from
Jan 23, 2024

Conversation

vlorinc
Copy link
Contributor

@vlorinc vlorinc commented Jan 23, 2024

Adds missing tests so that every dpdk client function is now covered.

Fixes minor bug that wrong kind was returned in ListNat function, now it returns correctly NeighborNat or Nat kind.

This PR resolves all TODOs from the client_test.

@vlorinc vlorinc requested a review from a team as a code owner January 23, 2024 09:46
@vlorinc vlorinc linked an issue Jan 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added enhancement New feature or request size/M labels Jan 23, 2024
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@guvenc guvenc merged commit 0dcdbd0 into main Jan 23, 2024
5 checks passed
@guvenc guvenc deleted the enh/automated_tests branch January 23, 2024 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tests
2 participants