Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of finite element classes #86

Open
SerafeimBakalakos opened this issue Jun 29, 2018 · 2 comments
Open

Refactoring of finite element classes #86

SerafeimBakalakos opened this issue Jun 29, 2018 · 2 comments
Assignees

Comments

@SerafeimBakalakos
Copy link
Member

Right now it is extremely difficult to reuse the code in these classes for other problem types, boundary conditions, etc.

@SerafeimBakalakos
Copy link
Member Author

  • I have decoupled the integration rules and interpolations (shape functions) from the finite elements. They can be used by the finite element classes or others.
  • All continuum finite elements are now represented by the same class, with different interpolations and integration rules. This decreases code duplication.
  • The above have been fully implemented and tested for Quad4 and Tri3 elements, as of yet.
  • Please take a glance at the new classes in ISAAR.MSolve.FEM.Integration, ISAAR.MSolve.FEM.Interpolation and ISAAR.MSolve.FEM.Elements and comment on how they can be improved (other than the missing non-linear and embedding functionality).

@dimtsap
Copy link
Member

dimtsap commented Jul 3, 2018

@SerafeimBakalakos I have almost completed the 3D case. Please note that some caching was missing so I corrected this in both 2D and 3D case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants