Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new .NET 5 lazy assembly loader #65

Open
isc30 opened this issue Sep 4, 2020 · 15 comments
Open

Support new .NET 5 lazy assembly loader #65

isc30 opened this issue Sep 4, 2020 · 15 comments
Labels
blocked blocker This task blocks others feature New feature or request needs help

Comments

@isc30
Copy link
Owner

isc30 commented Sep 4, 2020

Blazor team did a lot of work to introduce a partial implementation of the lib into blazor itself. This means that the LazyAssemblyLoader is a native part of blazor now! When .NET 5 RC1 is released, this library should shrink and reuse as much as it can from the official lazy loading support.

@isc30 isc30 added blocker This task blocks others feature New feature or request labels Sep 4, 2020
@knight1219
Copy link

Has there been any movement on this at all? I've been looking at this library as a way to help modularize a set of apps into Blazor and if it's using the native Blazor lazy loading that would be cool. This lib seems super easy to configure and use so I would love to start prototyping with it.

@isc30
Copy link
Owner Author

isc30 commented Oct 22, 2020

No movement cause R1 was super buggy. Now that they released R2 I'll give it another go and hopefully adapt the library to it :)

@isc30
Copy link
Owner Author

isc30 commented Oct 26, 2020

Had some time to look into this, some bits of the metadata generation are broken and need to investigate the .net5 internals to make it work. Will take some time.
If anyone wants to contribute i can push my changes and coordinate.

@Daeamon
Copy link

Daeamon commented Oct 27, 2020

If anyone wants

I'm want)

@ChristianWeyer
Copy link

Hi @isc30 - just a quick check whether you already know when you could have the .NET5-based new version available?
Thanks for the great lib!

@isc30
Copy link
Owner Author

isc30 commented Nov 14, 2020 via email

@ChristianWeyer
Copy link

:-)

@ChristianWeyer
Copy link

Sorry for disturbing again. Maybe you have a remote idea of when the ETA of this update might be? 😇 @isc30

@isc30
Copy link
Owner Author

isc30 commented Nov 17, 2020

Hi, since stable .net5 was released some days ago, I'm working on making it work for that specific version.
I expect to have it by this week.

@isc30
Copy link
Owner Author

isc30 commented Nov 19, 2020

@isc30
Copy link
Owner Author

isc30 commented Nov 19, 2020

Blocked by the following error when trying to execute the custom MsBuild Task: GenerateManifest
imagen

any ideas if net5.0 target dlls can contain msbuild Tasks?

@isc30
Copy link
Owner Author

isc30 commented Nov 19, 2020

Tried if porting only the components project to .net5 would help with the msbuild task issue but nothing.
After some days of fighting with this I'm out of ideas on how to make a custom MsBuild task work in .net5.....

There are 2 approaches I tried:

  • Porting everything to net5.0: feature/net5
  • Porting only blazor libraries to net5.0: feature/net5.0-only-components
    Both suffer from the same error I mentioned before.

When this gets fixed, missing work is to:

  • Implement a new LazyRouter that wraps the new <Router> and hooks into the new OnNavigateAsync and Navigating
  • Change AssemblyLoader internals to use the new LazyAssemblyLoader instead of doing the locate+fetch itself

@ChristianWeyer
Copy link

Did you ask over at the .NET Core repo? They are quite helpful, usually.

@isc30
Copy link
Owner Author

isc30 commented Nov 20, 2020

No, I didn't reach them. I will be trying using NestedTask this afternoon and will reach them if it doesn't work.
If you want to help, the easiest way is to checkout feature/net5.0-only-components, build BlazorLazyLoading.sln and then build demo/Demo.sln to see the error. If we manage to sort this out, the rest of the implementation is quite straightforward.

Please make sure you use the stable net5.0.0 sdk

@isc30
Copy link
Owner Author

isc30 commented Nov 20, 2020

I'll be available in https://gitter.im/Blazor-Lazy-Loading/community

@isc30 isc30 added the blocked label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocker This task blocks others feature New feature or request needs help
Projects
None yet
Development

No branches or pull requests

4 participants